Skip to content

Fold "new T[size].Length" into "size" #114845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Fold "new T[size].Length" into "size" #114845

merged 1 commit into from
Apr 22, 2025

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 20, 2025 •
edited
Loading

Closes #114744

static void Test(int count)
{
    int[] arrA = new int[count];
    float[] arrB = new float[count];
    for (int i = 0; i < count; i++)
    {
        arrA[i] = 0;     // bounds check
        arrB[i] = 0.0f;  // bounds check
    }
}

Codegen diff: https://www.diffchecker.com/7iCHeDLt/

Seems like this transformation produces nice SPMI diffs.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 20, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 20, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo EgorBo mentioned this pull request Apr 20, 2025
Open
29 tasks
@EgorBo EgorBo marked this pull request as ready for review April 20, 2025 17:02
Copilot AI review requested due to automatic review settings April 20, 2025 17:02
Copilot AI reviewed Apr 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements an optimization to fold the expression new T[size].Length into the original size argument, reducing unnecessary bounds checks and streamlining array length calculations.

  • Introduces a new folding case for ARR_LENGTH with new array expressions.
  • Handles different type cases (TYP_LONG and TYP_INT) to extract the original size.

@EgorBo
Copy link
Member Author

EgorBo commented Apr 20, 2025

PTAL @AndyAyersMS @jakobbotsch @dotnet/jit-contrib simple opt with diffs.

@EgorBo EgorBo requested a review from AndyAyersMS April 20, 2025 17:04
@neon-sunset

This comment was marked as resolved.

Sign in to view
@EgorBot EgorBot mentioned this pull request Apr 21, 2025
Open
@EgorBo EgorBo merged commit 8af737a into dotnet:main Apr 22, 2025
113 checks passed
@EgorBo EgorBo deleted the fold-arr-len-pattern branch April 22, 2025 11:33
This was referenced Apr 29, 2025
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Redundant bounds check for when loopUpperBound==arrayLength

3 participants

@EgorBo @neon-sunset @AndyAyersMS